Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapbox webpack resolver no longer needed in examples #577

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Mapbox webpack resolver no longer needed in examples #577

merged 1 commit into from
Aug 13, 2018

Conversation

schnerd
Copy link
Contributor

@schnerd schnerd commented Aug 13, 2018

Following Ib's comment in #121 about these webpack resolves no longer being needed. I tested using the draggable marker example and it worked fine.

@schnerd schnerd requested a review from ibgreen August 13, 2018 17:48
@schnerd schnerd mentioned this pull request Aug 13, 2018
Merged
ibgreen
ibgreen approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice boilerplate reduction!

@schnerd schnerd merged commit 489d338 into master Aug 13, 2018
@Pessimistress Pessimistress deleted the ds-update-webpack-resolve branch October 27, 2018 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schnerd @ibgreen